Skip to content

Enhance RLConfig Pydantic inheritance hierarchy and establish unified import and gradient accumulation conventions. - #4682

Merged
copybara-service[bot] merged 1 commit into
mainfrom
test_956792333
Aug 8, 2026
Merged

Enhance RLConfig Pydantic inheritance hierarchy and establish unified import and gradient accumulation conventions.#4682
copybara-service[bot] merged 1 commit into
mainfrom
test_956792333

Conversation

@copybara-service

@copybara-service copybara-service Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Enhance RLConfig Pydantic inheritance hierarchy and establish unified import and gradient accumulation conventions.

@copybara-service
copybara-service Bot force-pushed the test_956792333 branch 6 times, most recently from d6f48b4 to 7572635 Compare July 31, 2026 16:33
@copybara-service copybara-service Bot changed the title Align MaxTextTrainingEngine microbatch accumulation scaling and primary loss metric recording. Enhance RLConfig Pydantic inheritance hierarchy and establish unified import and gradient accumulation conventions. Aug 6, 2026
@copybara-service
copybara-service Bot requested a review from shuningjin as a code owner August 6, 2026 00:22
@copybara-service
copybara-service Bot force-pushed the test_956792333 branch 13 times, most recently from 480e1f9 to 9409dad Compare August 7, 2026 00:52
@codecov

codecov Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.62406% with 67 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/training_engine/maxtext_engine.py 48.85% 52 Missing and 15 partials ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot force-pushed the test_956792333 branch 9 times, most recently from 4ca1b1f to 59db7fd Compare August 7, 2026 23:48
@A9isha @Google-ML-Automation
Enhance RLConfig Pydantic inheritance hierarchy and establish unified…
5f2c70a 
… import and gradient accumulation conventions.

PiperOrigin-RevId: 961196736
@copybara-service
copybara-service Bot merged commit 5f2c70a into main Aug 8, 2026
@copybara-service
copybara-service Bot deleted the test_956792333 branch August 8, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson is a code owner
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner
@gagika gagika Awaiting requested review from gagika gagika is a code owner
@shralex shralex Awaiting requested review from shralex shralex is a code owner
@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner
@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner
@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner
@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner
@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner
@darisoy darisoy Awaiting requested review from darisoy darisoy is a code owner
@xibinliu xibinliu Awaiting requested review from xibinliu xibinliu is a code owner
@huytransformer huytransformer Awaiting requested review from huytransformer huytransformer is a code owner
@shuningjin shuningjin Awaiting requested review from shuningjin shuningjin is a code owner

Assignees

@A9isha A9isha

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@A9isha